-
Notifications
You must be signed in to change notification settings - Fork 13
LW-13680 Add FF_OVERRIDE env variable to locally override feature flags #2008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Allure Report
processReports: ✅ test report for 044170ad
|
427c988
to
ea0b673
Compare
apps/browser-extension-wallet/src/providers/PostHogClientProvider/client/PostHogClient.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the solution.
Please add the new variable to .env.defaults and an example to .env.examples. It should be clear that the overide keys must be the lowercase versions:
FF_OVERRIDE='{"notifications-center": false}'
not
FF_OVERRIDE='{"NOTIFICATIONS_CENTER": false}'
Example usage @ljagiela / @wklos-iohk : |
c6ae00f
to
3de9119
Compare
apps/browser-extension-wallet/src/providers/PostHogClientProvider/client/PostHogClient.ts
Outdated
Show resolved
Hide resolved
3de9119
to
044170a
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work @iccicci 🥇
Checklist
Proposed solution
Proposed the approach of a JSON encoded variable as after WebPack build we no longer have the power to dynamically access
process.env
.Following code
produces following logs
Proposed parsing as
boolean
as all FF have aboolean
value. Ref: isFeatureFlagEnabledTesting
Manually tested